linux.kernel Google Group

Re: [PATCH 2/2] perf top: Properly notify the user that vmlinux is missing

2010-03-15T19:30:03Z

Ok, I really think we should link with libopcodes or similar so we can
handle the simple assembler annotation case without requiring the
kernel image being available.
That's what I was trying to achieve when I sent you the report

Re: [PATCH 2/2] perf top: Properly notify the user that vmlinux is missing

2010-03-15T19:30:03Z

Em Mon, Mar 15, 2010 at 11:55:26AM -0700, David Miller escreveu:
Annotation is done by objdump -dS, that requires an executable file to
do ASM annotation, and one with DWARF info for source code annotation.
What we have with /proc/kallsyms is just the symtab.
- Arnaldo

Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-15T19:30:02Z

I really dislike the fact that drm has bus specific junk all over the
generic code. Some ideas how to clean that up:
Add 'struct device *dev' into drm_device so you don't have to go through
the pdev/platformdev to get it every time. Also use dev_name() instead
of pci_name() and whatever you used for the platform device case.

Re: [PATCH] USB: f_mass_storage: dynamic buffers for better alignment

2010-03-15T19:30:02Z

I have no opinion anymore :-p
I can only think about the devices I've been working on which would be a
pain to allocate so much memory and would suffer if you use vmalloc()
too, so both would be a no-no for me :-p
how about ?
for (i = FSG_NUM_BUFFER; i; i--, ++bh) {
bh->buf = kmalloc(FSG_BUFLEN, GFP_KERNEL);

[GIT PULL] Btrfs updates

2010-03-15T19:30:02Z

Hello everyone,
The master branch of the btrfs unstable tree has a collection of fixes
and features:
git://git.kernel.org/pub/scm/l inux/kernel/git/mason/btrfs-un stable.git master
If Linus decides this pull is too big/too late, we'll maintain a bug fix
only branch for .34 and keep this branch stable for people that want to

Re: [PATCH] USB: f_mass_storage: dynamic buffers for better alignment

2010-03-15T19:30:02Z

I admit, I haven't thought about that. Some fields rearrangement
could help avoid some padding but yes, it can be done.
However, there is one more thing I've had in mind. Each buffer
is 4 pages (16 KiB) and there are two such buffers in struct
fsg_common therefore the whole size of the structure is

Re: [PATCH] staging: winbond: mac_structures.h Fixed indentation, whitespace etc

2010-03-15T19:20:02Z

...which only shows how little problems checkpatch detects.
Get rid of revision history; it does not make sense, is not english,
and just should not be there.
Consistent tabs vs spaces?
Same here.
I thought you was killing C++ comments?
Commented out code should be killed, not commented out in nicer way.

[GIT PULL] omap fixes for 2.6.34-rc1

2010-03-15T19:20:02Z

Hi Linus,
Please pull omap fixes from:
git://git.kernel.org/pub/scm/l inux/kernel/git/tmlind/linux-o map-2.6.git omap-fixes-for-linus
Regards,
Tony
The following changes since commit 57d54889cd00db2752994b389ba714 138652e60c:
Linus Torvalds (1):
Linux 2.6.34-rc1
are available in the git repository at:

Re: [PATCH] net/netfilter/ipvs/ip_vs_ftp.c: Remove use of NIPQUAD

2010-03-15T19:10:02Z

Yes.

Re: [PATCH 1/4 v2] x86: remove rdc321x_defs.h

2010-03-15T19:10:02Z

Hi Ingo,
Thanks.
The MFD tree, yes.
Florian, I'll review those patches later this week, thanks.
Cheers,
Samuel.

Re: [Regression] r8169: enable 64-bit DMA by default for PCI Express devices (v2)

2010-03-15T19:00:02Z

RnJvbTogSsO2cm4gRW5nZWwgPGpvZX JuQGR1Ymxpbi5sb2dmcy5vcmc+DQpE YXRlOiBNb24sIDE1
IE1hciAyMDEwIDE2OjEwOjQxICswMT AwDQoNCj4gRm9yZ290IHRvIENjOiBs a21sLg0KDQpBY3R1
YWxseSwgd2hhdCB5b3UgcmVhbGx5IG 5lZWQgdG8gQ0M6IGlzIG5ldGRldiwg YWRkZWQuDQo+IE9u
IE1vbiwgMTUgTWFyY2ggMjAxMCAxNj owODowNiArMDEwMCwgSu+/vXJuIEVu Z2VsIHdyb3RlOg0K

Re: 64-syscall args on 32-bit vs syscall()

2010-03-15T19:00:01Z

There are many archs that still lack VDSO.

Re: [PATCH] init dynamic bin_attribute structures

2010-03-15T19:00:02Z

The firmware loader should be done differently:
[link]
and I suspect that Wolfram may have skipped the thermal one as having been
done by another patch (that I didn't merge, due to having questions about
the whole issue, but that I don't have any objections to)
But maybe there is also some limitation to the coccinelle rule too.

Re: [PATCH 2/2] perf top: Properly notify the user that vmlinux is missing

2010-03-15T19:00:02Z

Arnaldo, if perf top can use the kallsyms to do it's normal task, why
can't it use that for symbol annotations too? Isn't there enough
information available?

Re: [PATCH][RF C/T/D] Unmapped page cache control - via boot parameter

2010-03-15T18:50:01Z

Not really. In many cloud environments, there's a set of common images
that are instantiated on each node. Usually this is because you're
running a horizontally scalable application or because you're supporting
an ephemeral storage model.
In fact, with ephemeral storage, you typically want to use